Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JSON file with GAP appearance values from BT SiG #107

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Added JSON file with GAP appearance values from BT SiG #107

merged 1 commit into from
Jan 10, 2024

Conversation

eriklins
Copy link
Contributor

@eriklins eriklins commented Jan 3, 2024

As discussed with @dinesharjani in #106 here is my pull-request with gap_appearance.json file. This file has been automatically created from BT SiG bitbucket url @https://bitbucket.org/bluetooth-SIG/public/src/main/assigned_numbers/core/appearance_values.yaml with an own Python script. I did not modify any of the existing JS scripts since I couldn't fully figure which do what. I'm happy to update the appearance values on a regular basis, if need be.

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2024

CLA assistant check
All committers have signed the CLA.

@dinesharjani
Copy link
Collaborator

@eriklins Thanks! I'll have a look tomorrow if that's okay.

@dinesharjani dinesharjani added the enhancement New feature or request label Jan 10, 2024
@dinesharjani
Copy link
Collaborator

@eriklins All okay. You just need to accept the CLA

@dinesharjani dinesharjani self-requested a review January 10, 2024 10:23
@eriklins
Copy link
Contributor Author

@eriklins All okay. You just need to accept the CLA

Hi Dinesh, strange thing is, that I did accept the CLA already, see screenshot. No clues why it shows still pending with the PR. I selected "recheck", but not change. Not sure how to re-accept it, when clicking on the accept link, it won't let me do any changes but just says, that I already accepted.

2024-01-10 11_27_18-CLA assistant

@philips77
Copy link
Member

Hello,
You need to set the same e-mail address in Git for the commit you did. From GitHub perspective you, who did the commit (no e-mail) and you, who opened PR, are different people. The e-mail needs to match.
Have a look at this.

@eriklins
Copy link
Contributor Author

eriklins commented Jan 10, 2024

So, I did not use an email address for the commit (did this with Tortoise Git on my PC and seems I had not configured that properly, fixed it now) but just the username. How would I get this matched to the email address on github (where I did the PR), since there actually is no email address in the commit?

@dinesharjani
Copy link
Collaborator

So you can ammend your commit with your correct username and then git push -f to the branch with this PR

amend commit
sh: line 1: q: command not found
@eriklins
Copy link
Contributor Author

Thanks for the help Dinesh and Aleksander, seems it did work now.

@dinesharjani dinesharjani merged commit 1479d11 into NordicSemiconductor:master Jan 10, 2024
4 checks passed
@dinesharjani
Copy link
Collaborator

@eriklins thanks to you. Sorry about the delay regarding looking into this, because I had a swamp of other work things

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants