currentStoreView is empty in metaInfo #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix http 500 error: Don't assume accept header exists
Option to prevent fetch story
* Prepare for 1.11 * wip * Add CMS component * Fetch story * lint * Use substring * 1.11 changes * lint * Nicer code in api * Hardcode index * Prefer const * lint * Do not rely on imported db * Move getHitsAsStory to helper * Remove db.js * Update makefile * Update readme * Update API * Update readme * Nicer code * Restructure files * Restructure files * Update * Move image * Update to 1.11 * Remove RouterManager * Style adjustments * Update tsconfig * Try to make tests run * lint * Use new module loading syntax * Update readme * Guard alternates * Fix for new url format with leading slash (backport from 1.11) * Make compatible with config.storeViews.xx.appendStoreCode * Option to prevent fetch story * Fix http 500 error: Don't assume accept header exists * Fix return value * Fix broken meta description (fallback to config default per storeview) Co-authored-by: Max Malm <benjick@dumfan.net> Co-authored-by: Andreas Karlsson <andreas@kodbruket.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
metaInfo(),currentStoreView()only containsstoreCodeproperty. We need to get the other properties by getting the storeView fromconfig.Reference: vuestorefront/vue-storefront#3674