This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Fixes #10220: Inventories with fields containing only spaces/tabs/... may fail to be parsed due to invalid sanitization of entry #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
suggested changes
Feb 16, 2017
| case s => s.trim().replaceAll("""[\p{Blank}]+"""," ") match { | ||
| case "" => None | ||
| case text => Some(text) | ||
| } | ||
| } |
There was a problem hiding this comment.
If it's exactly the same method, in the same project, we should dedup it. It really smell like bugs waiting to happen.
For the code, it's ok. I'm not sure if it make more sense to have:
def optText(n:NodeSeq) = n.text match {
case null => None
case s => s.trim().replaceAll("""[\p{Blank}]+"""," ") match {
case "" => None
case text => Some(text)
}
}
so that the blank case is at the same place, but it's really not important.
… may fail to be parsed due to invalid sanitization of entry
|
Commit modified |
ncharles
force-pushed
the
bug_10220/inventories_with_fields_containing_only_spaces_tabs_may_fail_to_be_parsed_due_to_invalid_sanitization_of_entry
branch
from
301ba58
to
b5cf10c
Compare
ncharles
commented
Feb 16, 2017
| @@ -1078,3 +1069,20 @@ class FusionReportUnmarshaller( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| object OptText { | |||
There was a problem hiding this comment.
couldn't find a better name :(
|
OK, merging this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10220