This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Fixes #5445, Refs #5275: parse windows 2012 name correctly #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fanf could you review this PR please ? |
|
The code seems OK, modulo two things:
|
|
The branch is OK (we don't support that windows in 2.6) |
ncharles
force-pushed
the
bug_5275/dev/5445_parse_windows_2012_inventory
branch
from
c9f994a
to
f9ddd02
Compare
|
merging code after merging @fanf tests |
ncharles
added a commit
that referenced
this pull request
Oct 28, 2014
…2012_inventory Fixes #5445, Refs #5275: parse windows 2012 name correctly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.