Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15216: Add a generic method to ensure that a kernel module is loaded #1019

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Fixes #15216: Add a generic method to ensure that a kernel module is loaded #1019

merged 1 commit into from
Aug 21, 2019

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Jul 17, 2019

@Fdall
Copy link
Contributor Author

Fdall commented Jul 17, 2019

PR updated with a new commit

@Fdall
Copy link
Contributor Author

Fdall commented Jul 17, 2019

PR updated with a new commit

ncharles
ncharles requested changes Aug 20, 2019
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small wording change requested

tree/30_generic_methods/kernel_module_loaded.cf Outdated Show resolved Hide resolved
@Fdall
Copy link
Contributor Author

Fdall commented Aug 20, 2019

PR updated with a new commit

@Fdall Fdall requested a review from ncharles August 20, 2019 15:45
@ncharles
Copy link
Member

👍

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/1019
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/13981/console)

@Fdall
Copy link
Contributor Author

Fdall commented Aug 21, 2019

OK, squash merging this PR

@Fdall Fdall force-pushed the bug_15216/add_a_generic_method_to_ensure_that_a_kernel_module_is_loaded branch from 672eff6 to c6e6521 Compare August 21, 2019 14:45
@Fdall
Copy link
Contributor Author

Fdall commented Aug 21, 2019

OK, merging this PR

1 similar comment
@Fdall
Copy link
Contributor Author

Fdall commented Aug 21, 2019

OK, merging this PR

@Fdall Fdall merged commit c6e6521 into Normation:branches/rudder/5.0 Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset left review comments

@ncharles ncharles ncharles approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
4 participants
@Fdall @ncharles @Normation-Quality-Assistant @amousset