Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15507: Remove remaining function about delete api #1043

Merged
merged 1 commit into from Aug 20, 2019
Merged

Fixes #15507: Remove remaining function about delete api #1043

merged 1 commit into from Aug 20, 2019

Conversation

VinceMacBuche
Copy link
Member

ncharles
ncharles reviewed Aug 19, 2019
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md mention that hooks can be executed, yet i couldn't find the part in scala that would execute said script

@VinceMacBuche
Copy link
Member Author

There is no hooks anymore, they were only used as internal rudder purpose and we decided to not port it to Rudder code

@ncharles
Copy link
Member

So you need to remove the mention of them on the README.md

@VinceMacBuche VinceMacBuche force-pushed the bug_15507/remove_remaining_function_about_delete_api branch from 0e346bb to dc1e75f Compare August 20, 2019 07:31
@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche
Copy link
Member Author

yes, that what i did

@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the bug_15507/remove_remaining_function_about_delete_api branch from dc1e75f to 1514ef0 Compare August 20, 2019 07:35
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 1514ef0 into Normation:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@VinceMacBuche @ncharles @Normation-Quality-Assistant