Fixes #15522: zypper_pattern module does not work in python3 #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdall
commented
Aug 20, 2019
| @@ -65,7 +65,7 @@ def redirection_is_broken(): | |||
|
|
|||
| def subprocess_Popen(cmd, stdout=None, stderr=None): | |||
| if not redirection_is_broken() or (stdout is None and stderr is None) or stdout == subprocess.PIPE or stderr == subprocess.PIPE: | |||
| return subprocess.Popen(cmd, stdout=stdout, stderr=stderr) | |||
| return subprocess.Popen(cmd, stdout=stdout, stderr=stderr, universal_newlines=True) | |||
There was a problem hiding this comment.
This is to force subprocess buffer to be text buffer and not bytes buffer
amousset
approved these changes
Aug 20, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15522