Fixes #15783: Make class_prefix unique #1071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdall
commented
Sep 24, 2019
| # @class_prefix command_execution | ||
| # @class_parameter command_name | ||
|
|
||
| bundle agent command_execution(command_name) | ||
| { | ||
| vars: | ||
| "old_class_prefix" string => canonify("command_execution_${command_name}"); | ||
| "old_class_prefix" string => canonify("${report_data.canonified_directive_id}_command_execution_${command_name}"); |
There was a problem hiding this comment.
This is tricky we are changing the expected outcome classes, maybe we should add a third one ?
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
PR rebased |
Fdall
force-pushed
the
ust_15783/make_class_prefix_unique
branch
from
adb0cf0
to
373db52
Compare
|
Commit modified |
Fdall
force-pushed
the
ust_15783/make_class_prefix_unique
branch
from
373db52
to
7ce7197
Compare
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
PR rebased |
Fdall
force-pushed
the
ust_15783/make_class_prefix_unique
branch
from
177de25
to
821ea3b
Compare
ncharles
reviewed
Oct 3, 2019
| @@ -1173,7 +1173,7 @@ bundle agent ncf_services(service, action) | |||
| "canonified_action" string => canonify("${action}"); | |||
| "canonified_action_command" string => canonify("${action_command}"); | |||
|
|
|||
| "class_prefix" string => "ncf_services_${canonified_service}_${canonified_action}"; | |||
| "class_prefix" string => "${report_data.canonified_directive_id}_ncf_services_${canonified_service}_${canonified_action}"; | |||
There was a problem hiding this comment.
This breaks all services methods, that use "ncf_services_*" classes for all conditions
|
This not good enough, we should wait to have a proper id for each call done by the generation before trying to fix this, or it will seem super hacky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15783