Fixes #16078: Applying directives using the exact same GM with same parameters will always result in missing reports #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameters will always result in missing reports
ncharles
reviewed
Jan 13, 2020
| "full_class_prefix" string => canonify("directory_present_${report_param}"); | ||
| "class_prefix" string => string_head("${full_class_prefix}", "1000"); | ||
| "old_class_prefix" string => canonify("directory_present_${target}"); | ||
| "uniq_old_class_prefix" string => canonify("${report_data.directive_id}_directory_present_${target}"); |
There was a problem hiding this comment.
why do we need the uniq_old_class_prefix ?
|
This not good enough, we should wait to have a proper id for each call done by the generation before trying to fix this, or it will seem super hacky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16078