Fixes #12780: Do not store response when response code is an error in file_fom_http_server #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Nov 13, 2019
| @@ -20,12 +20,14 @@ | |||
| # @description Download a file if it does not exist, using curl with a fallback on wget | |||
| # @documentation This method finds a HTTP command-line tool and downloads the given source | |||
| # into the destination. | |||
| # | |||
| # | |||
| # This method `will NOT update the file after the first download` until its removal. | |||
There was a problem hiding this comment.
```````` is for code, use ** instead
|
PR updated with a new commit |
amousset
approved these changes
Nov 13, 2019
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
… file_fom_http_server
Fdall
force-pushed
the
bug_12780/do_not_store_response_when_response_code_is_an_error_in_file_fom_http_server
branch
from
b3f2406
to
5520d70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/12780