Fixes #16019: Close button in Generic Method tab is not working #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,7 +156,7 @@ <h1>You are not authenticated in ncf-builder</h1> | |||
| <div class="col-xl-4 col-5 col-techniques" ng-click="toggleDisplay(true)"> | |||
| <div class="row flex-column"> | |||
| <div class="col-auto"> | |||
| <div class="row" ng-if="ui.showTechniques"> | |||
There was a problem hiding this comment.
This was used to prevent the user from clicking on the "Import" button when the left menu is folded. We shouldn't remove it, or find another workaround for this bug
There was a problem hiding this comment.
I fixed by adding a css pointer-events, that disable click events https://css-tricks.com/almanac/properties/p/pointer-events/
VinceMacBuche
force-pushed
the
bug_16019/close_button_in_generic_method_tab_is_not_working
branch
from
b6988f7
to
1cc1d0c
Compare
|
Commit modified |
RaphaelGauthier
approved these changes
Dec 6, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16019