Fixes #16573: Technique resource modifications do not activate the save button #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1330,6 +1337,7 @@ $scope.onImportFileChange = function (fileEl) { | |||
| // If we were cloning a technique, remove its 'clone' state | |||
| savedTechnique.isClone = false; | |||
| $scope.originalTechnique = angular.copy(savedTechnique); | |||
| $scope.originalTechnique.resources = undefined; | |||
There was a problem hiding this comment.
can you add a comment here ? to explain the resources will be reset by resource manager if original technique resources are undefined ?
|
PR updated with a new commit |
VinceMacBuche
approved these changes
Feb 6, 2020
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_16573/technique_resource_modifications_do_not_activate_the_save_button
branch
from
7628b61
to
a2438c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16573