Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16691: "Technique diverges" bug still persists #1154

Closed
wants to merge 1 commit into from
Closed

Fixes #16691: "Technique diverges" bug still persists #1154

wants to merge 1 commit into from

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier RaphaelGauthier force-pushed the bug_16691/technique_diverges_bug_still_persists branch from 4158226 to d35df90 Compare March 12, 2020 16:16
@RaphaelGauthier
Copy link
Member Author

Commit modified

VinceMacBuche
VinceMacBuche previously approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@VinceMacBuche VinceMacBuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/1154
-- Your faithful QA
Kant merge: "Thoughts without content are empty, intuitions without concepts are blind."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/21556/console)

@VinceMacBuche VinceMacBuche dismissed their stale review March 17, 2020 11:05

Maybe remove approval to merge in anoter branch

@RaphaelGauthier
Copy link
Member Author

PR rebased

@RaphaelGauthier RaphaelGauthier force-pushed the bug_16691/technique_diverges_bug_still_persists branch from d35df90 to 66b89e9 Compare March 17, 2020 12:53
@RaphaelGauthier RaphaelGauthier force-pushed the bug_16691/technique_diverges_bug_still_persists branch from 66b89e9 to 6ee79f8 Compare March 17, 2020 13:16
@RaphaelGauthier RaphaelGauthier mentioned this pull request Mar 17, 2020
Merged
@RaphaelGauthier
Copy link
Member Author

PR replaced by #1156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RaphaelGauthier @Normation-Quality-Assistant @VinceMacBuche