Fixes #17134: Adapt technique editor to not call ncf api and add method to generate data for Rudder #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR rebased |
VinceMacBuche
force-pushed
the
ust_17134/adapt_technique_editor_to_not_call_ncf_api_and_add_method_to_generate_data_for_rudder
branch
2 times, most recently
from
6771300
to
9180250
Compare
|
PR updated with a new commit |
VinceMacBuche
force-pushed
the
ust_17134/adapt_technique_editor_to_not_call_ncf_api_and_add_method_to_generate_data_for_rudder
branch
from
a22f26b
to
46a8868
Compare
|
PR rebased |
amousset
reviewed
Apr 22, 2020
builder/js/ncf.js
Outdated
| @@ -1115,8 +1129,12 @@ $scope.onImportFileChange = function (fileEl) { | |||
| if (method_call.method_name in $scope.generic_methods ) { | |||
| var method = $scope.generic_methods[method_call.method_name]; | |||
| var class_parameter = method.class_parameter; | |||
| var param_index = method.bundle_args.indexOf(class_parameter); | |||
| return method_call.parameters[param_index]; | |||
| console.log(method) | |||
|
PR updated with a new commit |
amousset
reviewed
Apr 22, 2020
builder/js/ncf.js
Outdated
| @@ -449,7 +450,7 @@ function toTechUI (technique) { | |||
|
|
|||
| // Handle class_context | |||
| defineMethodClassContext(method_call) | |||
| method_call.parameters=$scope.getMethodParameters(method_call) | |||
| //method_call.parameters=$scope.getMethodParameters(method_call) | |||
There was a problem hiding this comment.
refresh the page :)
|
PR updated with a new commit |
amousset
reviewed
Apr 22, 2020
ncf
Outdated
| @@ -64,8 +88,15 @@ if __name__ == '__main__': | |||
| usage() | |||
| exit(1) | |||
|
|
|||
| pprint(sys.argv[1]) | |||
|
PR updated with a new commit |
amousset
reviewed
Apr 22, 2020
| category = technique["category"] if len(technique["category"]) > 0 else "ncf_techniques" | ||
| version = technique["version"] if len(technique["version"]) > 0 else "1.0" | ||
| techniqueFile = '/var/rudder/configuration-repository/techniques/'+category+"/"+ bundle_name +"/"+version+'/technique.json' | ||
| if not os.path.exists(techniqueFile): |
There was a problem hiding this comment.
what will update this file when it exists?
There was a problem hiding this comment.
If it's already written then it will be managed by Rudder (in fact the goal here is to bootstrap the technique.json file so that Rudder will enrich them)
|
PR updated with a new commit |
|
OK, squash merging this PR |
…od to generate data for Rudder
Normation-Quality-Assistant
force-pushed
the
ust_17134/adapt_technique_editor_to_not_call_ncf_api_and_add_method_to_generate_data_for_rudder
branch
from
db36454
to
ecacbde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17134