Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17229: Sync stdlib with 3.15.1 #1184

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Fixes #17229: Sync stdlib with 3.15.1 #1184

merged 1 commit into from
Apr 24, 2020

Conversation

amousset
Copy link
Member

@amousset amousset requested a review from ncharles April 24, 2020 15:37
@amousset
Copy link
Member Author

PR updated with a new commit

1 similar comment
@amousset
Copy link
Member Author

PR updated with a new commit

ncharles
ncharles reviewed Apr 24, 2020
View reviewed changes
tree/20_cfe_basics/def.cf Outdated
#
#####################################################################################

bundle agent def {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there already is a bundle def in Rudder-technique

@amousset
Copy link
Member Author

PR updated with a new commit

2 similar comments
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

ncharles
ncharles approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you

@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit e283b53 into Normation:branches/rudder/6.1 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @ncharles