Fixes #17095: Allow forcing a "None" component in reporting #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
requested changes
May 20, 2020
| @@ -728,3 +733,27 @@ bundle agent endExecution | |||
| * Any existing configuration policy will continue to be applied without change. * | |||
| *********************************************************************************"; | |||
| } | |||
| bundle agent rudder_set_force_component_none(mode) | |||
There was a problem hiding this comment.
you should advertise that it is necessary to call it twice: once to set the mode, and once to remove the mode, otherwise all reports would be Nonde
There was a problem hiding this comment.
also, that calling it with any text but "false" would make futur reports None
tree/20_cfe_basics/log_rudder.cf
Outdated
| classes => if_ok_cancel("rudder_report_force_component_none"); | ||
|
|
||
| classes: | ||
| # double negation, so that the default is dry_run (in case of error) |
|
PR updated with a new commit |
ncharles
approved these changes
May 24, 2020
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
arch_17095/allow_forcing_a_none_component_in_reporting
branch
from
d116b36
to
b5c3a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17095