Fixes #17793: Importing technique leads to a blocked editor #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
Jun 25, 2020
VinceMacBuche
requested changes
Jun 25, 2020
|
Commit modified |
ElaadF
force-pushed
the
bug_17793/importing_technique_leads_to_a_blocked_editor
branch
from
82aab5a
to
65571d3
Compare
| @@ -1337,7 +1382,7 @@ $scope.onImportFileChange = function (fileEl) { | |||
| ncfTechnique = data.data.techniques.technique; | |||
|
|
|||
| // Transform back ncfTechnique to UITechnique, that will make it ok | |||
| var savedTechnique = toTechUI(ncfTechnique); | |||
| var savedTechnique = toTechUI(ncfTechnique, 2.0); | |||
There was a problem hiding this comment.
In fact ... it does not work with an int, and you could simplify with 1 or 2
VinceMacBuche
approved these changes
Jun 25, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17793