Fixes #18177: Method shared folder should not state that you can use md5 as hash method #1239
Conversation
|
PR updated with a new commit |
| # | ||
| # @parameter hash_type Hash algorithm used to check if file is updated (sha256, sha512). Only used on Windows, ignored on Unix. default is sha256 | ||
| # # keep md5 and sha1 to support old generic methods, also add a default so you don't have to enter a value on linux, md5/sha1 should go to default | ||
| # @parameter_constraint hash_type "select" : [ "", "sha256", "sha512", "md5", "sha1" ] |
There was a problem hiding this comment.
This will still be displayed in the technique editor under the field as field info
There was a problem hiding this comment.
nope parameter description is limited to one line contrary to documentation
| # @parameter hash_type Hash algorithm used to check if file is updated (md5, sha1, sha256). Only used on Windows, ignored on Unix. | ||
| # @parameter_constraint hash_type "select" : [ "md5", "sha1", "sha256" ] | ||
| # | ||
| # @parameter hash_type Hash algorithm used to check if file is updated (sha256, sha512). Only used on Windows, ignored on Unix. default is sha256 |
There was a problem hiding this comment.
we can't have a default here because it would break windows method and we can't force windows plugin version sync easily
There was a problem hiding this comment.
(already thought about adding one as it really inconvenient on Linux, should have added a comment here)
There was a problem hiding this comment.
I think we can update it, we know all users of the plugins and can make them upgrade, it's so much a PITA
There was a problem hiding this comment.
then you need to actually define the default value in the CFengine code with a defaults promise.
There was a problem hiding this comment.
we don't need it in cfengine, and it can be empty
There was a problem hiding this comment.
The value will still be defined but empty
There was a problem hiding this comment.
indeed, we don't use it with CFEngine
|
OK, squash merging this PR |
…md5 as hash method
Normation-Quality-Assistant
force-pushed
the
bug_18177/method_shared_folder_should_not_state_that_you_can_use_md5_as_hash_method
branch
from
3534e9e
to
7c55cd9
Compare
https://issues.rudder.io/issues/18177