Fixes #18384: Create a file from remote template generic method #1249
Conversation
|
this is not tested yet |
ncharles
force-pushed
the
bug_18384/create_a_file_from_remote_template_generic_method
branch
from
f9de958
to
02fcf7b
Compare
|
Commit modified |
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
| "full_class_prefix" string => canonify("file_from_template_${report_param}"); | ||
| "class_prefix" string => string_head("${full_class_prefix}", "1000"); | ||
|
|
||
| "template_folder" string => "${sys.workdir}/templates/file_from_remote_template"; |
There was a problem hiding this comment.
there is a /var/rudder/tmp that already exists and the training tells user to use it for templates
There was a problem hiding this comment.
interesting, because File from template with type recommends the templates folder
It is common to use a specific folder to store those templates after copy, for example in
${sys.workdir}/templates/.
There was a problem hiding this comment.
/var/rudder/templates is not provided by the package, i think we should avoid multiplying things in /var/rudder
There was a problem hiding this comment.
so we should change the documentation on the others
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_18384/create_a_file_from_remote_template_generic_method
branch
from
355cd71
to
e7b1470
Compare
https://issues.rudder.io/issues/18384