Fixes #18512: variable from command does not always report an error when the command failed #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdall
force-pushed
the
bug_18512/variable_from_command_does_not_always_report_an_error_when_the_command_failed
branch
from
f523abe
to
df1add3
Compare
|
Commit modified |
…hen the command failed
Fdall
force-pushed
the
bug_18512/variable_from_command_does_not_always_report_an_error_when_the_command_failed
branch
from
df1add3
to
ed1e212
Compare
|
Commit modified |
peckpeck
reviewed
Nov 16, 2020
| @@ -53,12 +53,12 @@ bundle agent variable_string_from_command(variable_prefix, variable_name, comman | |||
| # for example when checking promises on the server. | |||
| pass1:: | |||
| # the cariage return is necessary if command ends by a comment | |||
| "temp" string => execresult("OUTPUT=${const.dollar}(/bin/true; ${command} | |||
| "temp" string => execresult("OUTPUT=${const.dollar}(/bin/true; 2>/dev/null ${command} | |||
peckpeck
approved these changes
Nov 18, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18512