Fixes #18705: calling file_key_value_present_in_ini_section on a yum repo definition loops #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repo definition loops
amousset
approved these changes
Nov 27, 2020
|
OK, merging this PR |
Fdall
reviewed
Nov 27, 2020
| "section[0]" string => "section_test1"; | ||
| "name[0]" string => "name1"; | ||
| "value[0]" string => "value1"; | ||
| "section[0]" string => "section_test1"; |
|
|
||
| # KEPT | ||
| # ensure that if the value is NOT modified | ||
| # but only in the selected region |
There was a problem hiding this comment.
This comment is most likely a copy-paste leftover
| "ph3" usebundle => apply_gm("file_key_value_present_in_ini_section", @{args3}, "${init.status[3]}", "ph3", "enforce" ); | ||
| "ph4" usebundle => apply_gm("file_key_value_present_in_ini_section", @{args4}, "${init.status[4]}", "ph4", "enforce" ); | ||
| "ph5" usebundle => apply_gm("file_key_value_present_in_ini_section", @{args5}, "${init.status[5]}", "ph5", "enforce" ); | ||
| "ph6" usebundle => apply_gm("file_key_value_present_in_ini_section", @{args6}, "${init.status[6]}", "ph6", "enforce" ); | ||
| } |
There was a problem hiding this comment.
Adding audit mode tests would be great
| @@ -459,6 +459,8 @@ bundle edit_line set_variable_values_ini(tab, sectionName) | |||
| # If the line is commented out with `#`, it gets uncommented first. | |||
There was a problem hiding this comment.
# If the key is commented out ....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18705