Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10713: Document when a parameter can be a regex #1294

Merged
merged 1 commit into from Aug 16, 2023
Merged

Fixes #10713: Document when a parameter can be a regex #1294

merged 1 commit into from Aug 16, 2023

Conversation

fanf
Copy link
Member

@fanf fanf commented May 19, 2021

@fanf fanf requested a review from amousset May 19, 2021 10:10
@fanf fanf added the Trigger test Trigger jenkins build label May 19, 2021
ncharles
ncharles previously requested changes May 12, 2022
View reviewed changes
tree/30_generic_methods/file_lines_absent.cf Outdated Show resolved Hide resolved
tree/30_generic_methods/file_lines_present.cf Outdated Show resolved Hide resolved
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/1294
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/63194/console)

@fanf fanf changed the base branch from branches/rudder/6.1 to branches/rudder/7.2 August 16, 2023 10:19
@fanf
Copy link
Member Author

fanf commented Aug 16, 2023

OK, squash merging this PR

@fanf fanf force-pushed the bug_10713/document_when_a_parameter_can_be_a_regex branch from 269a2ab to 0b9fe6d Compare August 16, 2023 10:30
@fanf fanf merged commit 0b9fe6d into Normation:branches/rudder/7.2 Aug 16, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

@ncharles ncharles ncharles left review comments

@amousset amousset Awaiting requested review from amousset

Assignees
No one assigned
Labels
qa: Can't merge Trigger test Trigger jenkins build
Projects
None yet
Milestone
No milestone
4 participants
@fanf @Normation-Quality-Assistant @ncharles @VinceMacBuche