Fixes #19411: Add new methods tests #1300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexis Mousset <contact@amousset.me>
Fdall
commented
Jun 8, 2021
amousset
reviewed
Jun 8, 2021
|
|
||
| "check install with latest version" | ||
| usebundle => package_install_version_cmp_update("${package_name}", "==", "latest", "verify", "false"); | ||
| "check install" usebundle => ncf_package("${package_name}", "any", "", "", "present", ""); |
There was a problem hiding this comment.
this completely changes the implementation, it shouldn't be done in a patch release
Fdall
force-pushed
the
bug_19411/add_new_methods_tests
branch
from
4215d18
to
b13e742
Compare
|
PR replaced by #1301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/19411