Fixes #20017: generic method parameter name must not change between 6.2 and 7.0 #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
added
Trigger test
|
PR updated with a new commit |
amousset
reviewed
Sep 29, 2021
| scope => "namespace"; | ||
|
|
||
| methods: | ||
| "success" usebundle => _classes_success("${old_class_prefix}"); | ||
| "success" usebundle => _classes_success("${class_prefix}"); | ||
|
|
||
| "report" usebundle => _log_v3("Create the condition ${condition}_{true,false} from the existence of variable ${variable_name}", "${condition}", "${old_class_prefix}", "${class_prefix}", @{args}); | ||
| "report" usebundle => _log_v3("Create the condition ${condition_prefix}_{true,false} from the existence of variable ${variable_name}", "${condition}", "${old_class_prefix}", "${class_prefix}", @{args}); |
There was a problem hiding this comment.
only the first occurence in the line is modified
peckpeck
added
Trigger test
|
PR updated with a new commit |
amousset
approved these changes
Sep 29, 2021
peckpeck
added
Trigger test
peckpeck
force-pushed
the
bug_20017/generic_method_parameter_name_must_not_change_between_6_2_and_7_0
branch
from
be45a9e
to
f987300
Compare
peckpeck
added
Trigger test
|
PR updated with a new commit |
|
OK, squash merging this PR |
VinceMacBuche
force-pushed
the
bug_20017/generic_method_parameter_name_must_not_change_between_6_2_and_7_0
branch
from
1fa7463
to
37f72f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20017