Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20374: Test ncf in docker #1325

Merged
merged 1 commit into from Dec 7, 2021
Merged

Fixes #20374: Test ncf in docker #1325

merged 1 commit into from Dec 7, 2021

Conversation

amousset
Copy link
Member

@amousset amousset commented Dec 6, 2021

@amousset amousset requested a review from Fdall December 6, 2021 23:27
@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 6, 2021
@amousset
Copy link
Member Author

amousset commented Dec 6, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 6, 2021
@amousset
Copy link
Member Author

amousset commented Dec 6, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 6, 2021
@amousset
Copy link
Member Author

amousset commented Dec 6, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 6, 2021
@amousset
Copy link
Member Author

amousset commented Dec 6, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 6, 2021
@amousset
Copy link
Member Author

amousset commented Dec 6, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 6, 2021
@amousset
Copy link
Member Author

amousset commented Dec 6, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 6, 2021
@amousset
Copy link
Member Author

amousset commented Dec 6, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

@amousset amousset removed the Trigger test Trigger jenkins build label Dec 7, 2021
@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

@amousset amousset added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Dec 7, 2021
@amousset
Copy link
Member Author

amousset commented Dec 7, 2021

PR updated with a new commit

Fdall
Fdall reviewed Dec 7, 2021
View reviewed changes
Jenkinsfile
axes {
axis {
name 'OS'
values 'debian:11'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile is a ubuntu20 based one, not debian11

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad

@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 4523262 into Normation:branches/rudder/6.1 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdall Fdall Fdall approved these changes

Assignees
No one assigned
Labels
Trigger test Trigger jenkins build
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @Fdall