Fixes #20944: Broken reporting for double nested method calls #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Mar 28, 2022
| "stack_len" int => length("method_id_unique.stack"); | ||
| "method_id" string => nth("method_id_unique.stack", "0"); |
There was a problem hiding this comment.
I think that method_id should be only the stack is not empty
so here
not_empty_stack.!pass2::
"method_id" string => nth("method_id_unique.stack", "0");
and
pass1.!pass2::
"not_empty_stack" expression => isgreaterthan("${stack_len}", "0");
amousset
added
Trigger test
|
PR updated with a new commit |
amousset
added
Trigger test
|
PR updated with a new commit |
ncharles
reviewed
Mar 29, 2022
| @@ -48,7 +48,6 @@ bundle agent service_stopped(name) | |||
| "${report_data.method_id}_${name}" usebundle => call_method("ncf_services_check"); | |||
| "${report_data.method_id}_${name}" usebundle => ncf_services("${name}", "is-active"); | |||
| "${report_data.method_id}_${name}" usebundle => call_method_classes("${report_data.method_id}_ncf_services_check"); | |||
| "${report_data.method_id}_${name}" usebundle => call_method_classes_caller; | |||
ncharles
approved these changes
Mar 29, 2022
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_20944/broken_reporting_for_double_nested_method_calls
branch
from
091dce2
to
ea8bd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20944