Fixes #21011: report_if_condition method does not support expressions in its input #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,6 +50,8 @@ bundle agent report_if_condition(report_message, condition) | |||
| if => "${condition}"; | |||
| "extended_message" string => "${report_message} was incorrect", | |||
| if => not("${condition}"); | |||
| classes: | |||
| "local_expression" expression => "${condition}"; | |||
There was a problem hiding this comment.
You also need to change all if below from "condition" to "local_expression"
There was a problem hiding this comment.
From what i read in documentation this should be ok ...
Fdall
added
Trigger test
|
PR updated with a new commit |
VinceMacBuche
approved these changes
Apr 21, 2022
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_21011/report_if_condition_method_does_not_support_expressions_in_its_input
branch
from
4990049
to
1150260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21011