Fixes #22240: Changes only does not support campaign reports #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
approved these changes
Jan 5, 2023
ncharles
reviewed
Jan 5, 2023
| @@ -730,6 +730,7 @@ bundle agent rudder_common_report_index(technique_name, status, identifier, comp | |||
| strcmp("${status}", "log_repaired") , | |||
| strcmp("${status}", "audit_noncompliant") , | |||
| strcmp("${status}", "audit_error") , | |||
| strcmp("${status}", "report_json") , | |||
There was a problem hiding this comment.
it should be in _rudder_common_report also
ncharles
requested changes
Jan 5, 2023
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_22240/changes_only_does_not_support_campaign_reports
branch
from
e3bfeee
to
5b6a9e2
Compare
ncharles
approved these changes
Feb 13, 2023
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22240