Fixes #23347: Improve variable_string_from_command by using execresult_as_data #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
Fdall
approved these changes
Aug 25, 2023
|
This does not work when the command comes from the test module, for some reason. We need to figure it out. |
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
arch_23347/improve_variable_string_from_command_by_using_execresult_as_data
branch
from
5a9c9b1
to
6fd1b61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23347
Remove the accumulated cruft that caused multiple bugs and use the "new"
execresult_as_data_method, now we don't need compatibility with 6.2 anymore.Note: Due to https://northerntech.atlassian.net/browse/CFE-4244 I had to re-introduce an ugly hack (a command at the end of the command) to allow our tests to pass (and avoid running into errors when running the same command in different methods).