Fixes #7156: Modify generic methods to define and use the new class_prefix #226
Conversation
| methods: | ||
| "placeholder" usebundle => file_copy_from_local_source_recursion("${source}", "${destination}", "0"); | ||
| "copy without recursion" usebundle => file_copy_from_local_source_recursion("${source}", "${destination}", "0"); | ||
| "new result classes" usebundle => _classes_copy("${class_prefix}", "${new_class_prefix}"); |
There was a problem hiding this comment.
i'm not sure of the result here.
If you call twice file_copy_from_local_source_recursion, with same destination, you won't be able to differenciate the results (the class_prefix will be the same)
There was a problem hiding this comment.
The second time you call the file_copy_from_local_source method, you will have a different promiser, which will give a different stack from here, hence a different new_class_prefix.
We will still have a common class_prefix, but we we cannot get rid of it until we are sure that the promiser stack feature is supported.
There was a problem hiding this comment.
_class_copy cpy class_prefix (old value) into new_class_prefix (new value)
So the new promiser will be overriden by the old one (no way to distringuish if it is the previous call or this call that defined the _error or the _success)
There was a problem hiding this comment.
Oh yes, then we'll have to define the classes at the source, ie define both in a new body classes
|
PR updated |
peckpeck
force-pushed
the
arch_7156/modify_generic_methods_to_define_and_use_the_new_class_prefix
branch
from
f1fd4b6
to
57b6d24
Compare
|
Do not merge now, I will rename class_prefix to old_class_prefix and new_class_prefix to class_prefix |
|
PR updated |
peckpeck
force-pushed
the
arch_7156/modify_generic_methods_to_define_and_use_the_new_class_prefix
branch
from
57b6d24
to
0279d43
Compare
| methods: | ||
| "placeholder" usebundle => file_copy_from_local_source_recursion("${source}", "${destination}", "0"); | ||
| "copy without recursion" usebundle => file_copy_from_local_source_recursion("${source}", "${destination}", "0"); | ||
| "new result classes" usebundle => _classes_copy("${class_prefix}_copy_without_recursion", "${class_prefix}"); |
There was a problem hiding this comment.
No, because the sub method already does it.
The logger refactoring will occur in a future PR.
|
PR updated |
peckpeck
force-pushed
the
arch_7156/modify_generic_methods_to_define_and_use_the_new_class_prefix
branch
from
0279d43
to
bde51e4
Compare
| # WARNING !!! | ||
| # For new class prefix migration only, this will be removed when migration is over | ||
| # Define x and y prefixed/suffixed with promise outcome | ||
| body classes classes_generic_two(x,y) |
There was a problem hiding this comment.
x and y are really bad names :(
There was a problem hiding this comment.
This is merely a copy of the stdlib code.
peckpeck
force-pushed
the
arch_7156/modify_generic_methods_to_define_and_use_the_new_class_prefix
branch
from
bde51e4
to
61d9dd0
Compare
peckpeck
force-pushed
the
arch_7156/modify_generic_methods_to_define_and_use_the_new_class_prefix
branch
from
61d9dd0
to
3a9cc2d
Compare
…s_to_define_and_use_the_new_class_prefix Fixes #7156: Modify generic methods to define and use the new class_prefix
https://www.rudder-project.org/redmine/issues/7156