Fixes #7157: Use the new class_prefix in reporting #229
Conversation
|
PR updated |
peckpeck
force-pushed
the
arch_7157/use_the_new_class_prefix_in_reporting
branch
from
185fcc5
to
ea9d111
Compare
|
PR updated |
peckpeck
force-pushed
the
arch_7157/use_the_new_class_prefix_in_reporting
branch
from
ea9d111
to
7898754
Compare
| "logging" usebundle => _bundle_caller_two("${configuration.enabled_loggers}", "${message}" , "${class_prefix}"); | ||
|
|
||
| "${method}" | ||
| usebundle => ${method}("${message}", "${old_class_prefix}", "${args}"), |
There was a problem hiding this comment.
can't you directly ${configuration.enabled_loggers}("${message}", "${old_class_prefix}", "${args}") ?
|
This is really neat ! |
peckpeck
force-pushed
the
arch_7157/use_the_new_class_prefix_in_reporting
branch
from
7898754
to
e68a0b9
Compare
|
PR updated |
|
|
||
| # 4/ Array is ready, reporting time !!! | ||
| "any" usebundle => _rudder_common_reports_generic("${report_data[1]}", "${c_class_prefix}", "${report_data[3]}", "${report_data[4]}", "${report_data[5]}", "${message}"), | ||
| classes => classes_generic("logger_rudder_${c_class_prefix}"); | ||
|
|
||
| # We HAVE the data and we CAN dot it -> New reporting method | ||
| report_v2:: |
There was a problem hiding this comment.
shouldn't this be:
report_v2.report_data_read.!no_old_class_prefix:: ?
There was a problem hiding this comment.
No:
- report_data_read is specific to report v1 so it is not needed here
- no_old_class_prefix is used to remove v1 style reporting, but not v2 style
There was a problem hiding this comment.
You should at least have logger_rudder_final_resfile no ?
Otherwise the file will not have been finished; or is it is not necessary, then in case of v2 report, the file .res should not be created
There was a problem hiding this comment.
Or, can you have both v1 and v2 ?
What happen if the first report line is a v2 ?
There was a problem hiding this comment.
ha, I understood, ok
report_v2 can only be put if expected_report_v2_res
|
PR updated |
peckpeck
force-pushed
the
arch_7157/use_the_new_class_prefix_in_reporting
branch
from
e68a0b9
to
a31c7c5
Compare
|
Yay ! |
…fix_in_reporting Fixes #7157: Use the new class_prefix in reporting
https://www.rudder-project.org/redmine/issues/7157