Fixes #7278: Add new class parameter to command_execution_* #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated |
peckpeck
force-pushed
the
ust_7278/add_new_class_parameter_to_command_execution
branch
from
25cbede
to
569f054
Compare
|
Original PR #234 |
| @@ -368,6 +368,58 @@ body classes classes_generic_return_codes_two(x, y, kept_return_code, repaired_r | |||
| "promise_kept_$(y)", "$(y)_kept", "$(y)_ok", "$(y)_not_repaired", "$(y)_reached" }; | |||
| } | |||
|
|
|||
| # Define x prefixes/suffixed with promises outcome, based on return codes | |||
| body classes classes_generic_return_codes_two(x, y, kept_return_codes, repaired_return_codes) | |||
There was a problem hiding this comment.
the name isn't really helpful in why it differs from the previous method
I forsee a lot of errors for users in the names of the methods (s or no s, that is the question ...)
peckpeck
force-pushed
the
ust_7278/add_new_class_parameter_to_command_execution
branch
from
569f054
to
b1be381
Compare
|
PR updated |
| } | ||
|
|
||
| # Define x prefixes/suffixed with true/false outcome, based on return codes | ||
| body classes classes_generic_return_boolean_two(x, y, boolean_prefix, true_return_codes, false_return_codes) |
There was a problem hiding this comment.
why not classes_generic_return_boolean_list_two ?
|
PR updated |
peckpeck
force-pushed
the
ust_7278/add_new_class_parameter_to_command_execution
branch
from
b1be381
to
5cf5e6a
Compare
ncharles
added a commit
that referenced
this pull request
Oct 22, 2015
…r_to_command_execution Fixes #7278: Add new class parameter to command_execution_*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7278