-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7279: Add generic methods to create conditions #254
Fixes #7279: Add generic methods to create conditions #254
Conversation
Original PR #234 |
i'm waiting for you tu update #247 and apply same correction here before reviewing it |
One #247 is merged i will rebase this one, which will make much shorter. |
could you rebase it now that #247 is merged ? |
PR updated |
0455b7b
to
2d6b16d
Compare
PR updated |
2d6b16d
to
3e44962
Compare
@@ -0,0 +1,63 @@ | |||
####################################################### | |||
# | |||
# Launch the /bin/date command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong comment
except from comment issue, everything looks good |
3e44962
to
5d4af76
Compare
PR updated |
@peckpeck i don't see the changes |
PR updated |
a8cddd4
to
d3ea703
Compare
PR updated |
if [ ! -x "$CF_KEY" ]; then | ||
echo "ERROR can't find cf-key. Are you sure you're running this from OBJDIR or OBJDIR/tests/acceptance? Check cf-key = '$CF_KEY'" | ||
exit 1 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should go in another PR
PR updated |
d3ea703
to
02bdcf0
Compare
"class_prefix" string => canonify(join("_", "this.callers_promisers")); | ||
"args" slist => { "${condition_prefix}", "${command}", "${true_codes}", "${false_codes}" }; | ||
|
||
"true_list" slist => string_split("${true_codes}", "\s*,\s*", "256"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you really don't want to use splitstring ?
PR updated |
02bdcf0
to
ddc9f8f
Compare
…_create_conditions Fixes #7279: Add generic methods to create conditions
https://www.rudder-project.org/redmine/issues/7279