Fixes #7279: Add generic methods to create conditions #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original PR #234 |
|
i'm waiting for you tu update #247 and apply same correction here before reviewing it |
|
One #247 is merged i will rebase this one, which will make much shorter. |
|
could you rebase it now that #247 is merged ? |
|
PR updated |
peckpeck
force-pushed
the
ust_7279/add_generic_methods_to_create_conditions
branch
from
0455b7b
to
2d6b16d
Compare
|
PR updated |
peckpeck
force-pushed
the
ust_7279/add_generic_methods_to_create_conditions
branch
from
2d6b16d
to
3e44962
Compare
| @@ -0,0 +1,63 @@ | |||
| ####################################################### | |||
| # | |||
| # Launch the /bin/date command | |||
|
except from comment issue, everything looks good |
peckpeck
force-pushed
the
ust_7279/add_generic_methods_to_create_conditions
branch
from
3e44962
to
5d4af76
Compare
|
PR updated |
|
@peckpeck i don't see the changes |
|
PR updated |
peckpeck
force-pushed
the
ust_7279/add_generic_methods_to_create_conditions
branch
2 times, most recently
from
a8cddd4
to
d3ea703
Compare
|
PR updated |
| if [ ! -x "$CF_KEY" ]; then | ||
| echo "ERROR can't find cf-key. Are you sure you're running this from OBJDIR or OBJDIR/tests/acceptance? Check cf-key = '$CF_KEY'" | ||
| exit 1 | ||
| fi |
|
PR updated |
peckpeck
force-pushed
the
ust_7279/add_generic_methods_to_create_conditions
branch
from
d3ea703
to
02bdcf0
Compare
| "class_prefix" string => canonify(join("_", "this.callers_promisers")); | ||
| "args" slist => { "${condition_prefix}", "${command}", "${true_codes}", "${false_codes}" }; | ||
|
|
||
| "true_list" slist => string_split("${true_codes}", "\s*,\s*", "256"); |
There was a problem hiding this comment.
you really don't want to use splitstring ?
|
PR updated |
peckpeck
force-pushed
the
ust_7279/add_generic_methods_to_create_conditions
branch
from
02bdcf0
to
ddc9f8f
Compare
ncharles
added a commit
that referenced
this pull request
Nov 4, 2015
…_create_conditions Fixes #7279: Add generic methods to create conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7279