Fixes #7436: Techniques that call _logger, _logger_default or logger_rudder will break because these methods take 4 arguments now and no upgrade path has been planned #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck we never use logger* again
…rudder will break because these methods take 4 arguments now and no upgrade path has been planned
| @@ -31,9 +31,13 @@ | |||
|
|
|||
| bundle agent _logger(message, old_class_prefix, origin_class_prefix, args) | |||
There was a problem hiding this comment.
shouldn't you change the signature of the method ?
There was a problem hiding this comment.
Oops. Well spotted, thanks. Fixed.
jooooooon
force-pushed
the
bug_7436/techniques_that_call_logger_logger_default_or_logger_rudder_will_break_because_these_methods_take_4_arguments_now_and_no_upgrade_path_has_been_planned_2
branch
from
8ef9127
to
4e3ee64
Compare
|
PR updated |
jooooooon
force-pushed
the
bug_7436/techniques_that_call_logger_logger_default_or_logger_rudder_will_break_because_these_methods_take_4_arguments_now_and_no_upgrade_path_has_been_planned_2
branch
from
4e3ee64
to
4f5f0ea
Compare
| # @parameter origin_class_prefix The prefix of the class for different states (1.x version) | ||
| # @parameter args The arguments used to call the generic method (slist) | ||
| # | ||
| # @class_prefix _logger_default |
There was a problem hiding this comment.
why the class prefix ? i'm pretty sure there's none of them
There was a problem hiding this comment.
why the class prefix ? i'm pretty sure there's none of them
All bundles must have a class_prefix. It's our internal style tests' policy. If we don't have one, tests will fail.
Also, there has always been one in this file, I just copied it without changing this line (see the individual commits, rather than the general overview)
jooooooon
force-pushed
the
bug_7436/techniques_that_call_logger_logger_default_or_logger_rudder_will_break_because_these_methods_take_4_arguments_now_and_no_upgrade_path_has_been_planned_2
branch
from
4f5f0ea
to
d84d81b
Compare
jooooooon
force-pushed
the
bug_7436/techniques_that_call_logger_logger_default_or_logger_rudder_will_break_because_these_methods_take_4_arguments_now_and_no_upgrade_path_has_been_planned_2
branch
from
d84d81b
to
984f42d
Compare
peckpeck
added a commit
that referenced
this pull request
Nov 23, 2015
…logger_logger_default_or_logger_rudder_will_break_because_these_methods_take_4_arguments_now_and_no_upgrade_path_has_been_planned_2 Fixes #7436: Techniques that call _logger, _logger_default or logger_rudder will break because these methods take 4 arguments now and no upgrade path has been planned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7436