Fixes #7461: classes_* methods should refuse to copy classes to a prefix which is an empty string #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,9 +37,10 @@ bundle agent test | |||
| "ph2" usebundle => file_ensure_lines_absent("${init.file}", "sample one"); # should get success | |||
| "ph3" usebundle => file_ensure_lines_absent("/dev/zero", "sample three"); # should get failed | |||
|
|
|||
| "ph1" usebundle => _classes_copy("file_ensure_lines_absent_${init.file_canon}","global_classA"); | |||
| "ph2" usebundle => _classes_copy("file_ensure_lines_present_${init.file_canon}","global_classB"); | |||
There was a problem hiding this comment.
Why do you change the ordering ?
There was a problem hiding this comment.
Because the original ordering made no sense. Now, the order matches the order of the calls above.
…fix which is an empty string
|
PR updated |
jooooooon
force-pushed
the
bug_7461/classes_methods_should_refuse_to_copy_classes_to_a_prefix_which_is_an_empty_string
branch
from
80690bf
to
db3c3d0
Compare
|
Good, merging |
peckpeck
added a commit
that referenced
this pull request
Nov 24, 2015
…d_refuse_to_copy_classes_to_a_prefix_which_is_an_empty_string Fixes #7461: classes_* methods should refuse to copy classes to a prefix which is an empty string
| @@ -38,6 +39,10 @@ bundle agent _classes_success(class_prefix) | |||
| "local_${suffix}" | |||
| string => "${class_prefix}_${suffix}", | |||
| classes => always("${class_prefix}_${suffix}"); | |||
|
|
|||
| classes: | |||
| "destination_exists" not => strcmp("${class_prefix}", ""); | |||
There was a problem hiding this comment.
shouldn't it report a warning if an empty string is passed?
There was a problem hiding this comment.
In master we use this property in every generic method so that calls don't fail when this.caller_promisers doesn't exist. So it could be a warning, but not in the general case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7461