Fixes #7558: http_request_* port to use new log interface on master #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,8 +46,9 @@ bundle agent http_request_check_status_headers(method, url, expected_status, hea | |||
| "report" usebundle => _log("Performing a HTTP ${method} request on ${url}, expecting status ${expected_status}", "${old_class_prefix}", "${class_prefix}", @{args}); | |||
|
|
|||
| !_stdlib_path_exists_curl:: | |||
| "force_failure_class_old" usebundle => _classes_failure("${old_class_prefix}"); | |||
There was a problem hiding this comment.
The fail report below. Is it not needed?
|
PR updated |
jooooooon
force-pushed
the
bug_7558/http_request_port_to_use_new_log_interface_on_master
branch
from
745d207
to
2e9a33a
Compare
|
OK merging |
peckpeck
added a commit
that referenced
this pull request
Dec 8, 2015
…use_new_log_interface_on_master Fixes #7558: http_request_* port to use new log interface on master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7558