Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8259: Delete/Up/Down buttons are not visible in generic methods which have a long description #358

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion builder/css/custom.css
Expand Up @@ -123,7 +123,9 @@ a:hover {
.icon-margin {
margin: 0 5px;
}

.method-settings .icon-margin {
margin: 0 3px;
}
.method-actions {
opacity: 0.3 ;
}
Expand Down Expand Up @@ -303,6 +305,8 @@ ul[dnd-list] .dndPlaceholder {
.btn.btn-method {
padding: 0;
overflow:hidden;
text-align: left;
white-space: normal;
}

ul[dnd-list] {
Expand Down Expand Up @@ -342,3 +346,8 @@ ul[dnd-list] {
font-size: 16px;
margin: 0;
}

.method-settings{
position: absolute;
right: 10px;
}
10 changes: 6 additions & 4 deletions builder/index.html
Expand Up @@ -195,16 +195,18 @@ <h3 >{{originalTechnique.name}} <span ng-hide="originalTechnique.name">New Techn
<span class="input-group-addon cursorMove"><b>:::</b></span>
<div class="panel-heading" style="overflow:hidden">
<h4 class="panel-title">
<div class="method-settings">
<i type="button" class="glyphicon glyphicon-circle-arrow-up icon-margin method-actions" aria-hidden="true" ng-hide="$index === 0" ng-click="moveDown($index); $event.stopPropagation();"></i>
<i type="button" class="glyphicon glyphicon-circle-arrow-down icon-margin method-actions" aria-hidden="true" ng-hide="$index === selectedTechnique.method_calls.length - 1" ng-click="moveUp($index); $event.stopPropagation();"></i>
<i aria-hidden="true" class="glyphicon glyphicon-remove-sign icon-margin icon-delete method-actions" ng-click="removeMethod($index); $event.stopPropagation();"></i>
<i type="button" class="glyphicon icon-margin" ng-class="{'glyphicon-chevron-left': isSelectedMethod(method_call), 'glyphicon-chevron-right': !isSelectedMethod(method_call)}"></i>
</div>
<span class="pull-left">
{{getMethodName(method_call)}}
<a ng-click="$event.stopPropagation();" target="_blank" ng-href="http://www.ncf.io/pages/reference.html#{{getMethodBundleName(method_call)}}">
<i class="glyphicon glyphicon-info-sign method-actions grey-icon"></i>
</a>
</span>
<i type="button" class="glyphicon pull-right icon-margin" ng-class="{'glyphicon-chevron-left': isSelectedMethod(method_call), 'glyphicon-chevron-right': !isSelectedMethod(method_call)}"></i>
<i aria-hidden="true" class="glyphicon glyphicon-remove-sign pull-right icon-margin icon-delete method-actions" ng-click="removeMethod($index); $event.stopPropagation();"></i>
<i type="button" class="glyphicon glyphicon-circle-arrow-down pull-right icon-margin method-actions" aria-hidden="true" ng-hide="$index === selectedTechnique.method_calls.length - 1" ng-click="moveUp($index); $event.stopPropagation();"></i>
<i type="button" class="glyphicon glyphicon-circle-arrow-up pull-right icon-margin method-actions" aria-hidden="true" ng-hide="$index === 0" ng-click="moveDown($index); $event.stopPropagation();"></i>
<br style="clear:both"/>
<small class="pull-left method-margin" >
{{getMethodDescription(method_call)}}
Expand Down