Fixes #8360: Method and technique are not correctly identified leady to wrong behavior in UI (Reset, Save) #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated |
VinceMacBuche
force-pushed
the
bug_8360/method_and_technique_are_not_correctly_identified_leady_to_wrong_behavior_in_ui_reset_save
branch
from
21b6309
to
d6c9680
Compare
|
PR updated |
VinceMacBuche
force-pushed
the
bug_8360/method_and_technique_are_not_correctly_identified_leady_to_wrong_behavior_in_ui_reset_save
branch
from
d6c9680
to
a3d7a86
Compare
| // Function to use after save is done | ||
| // Update selected technique if it's still the same technique | ||
| // update technique from the tree | ||
| var saveSuccess = function(data, status, headers, config) { | ||
| // Transform back ncfTechnique to UITechnique, that will make it ok | ||
| technique = toTechUI(technique); |
There was a problem hiding this comment.
could you use another name ? otherwise we won't know when we are handling a techNCF or techUI
|
appart from the comment, it looks great, thank you |
…g to wrong behavior in UI (Reset, Save)
|
PR updated |
VinceMacBuche
force-pushed
the
bug_8360/method_and_technique_are_not_correctly_identified_leady_to_wrong_behavior_in_ui_reset_save
branch
from
a3d7a86
to
e7bbaa6
Compare
|
ok, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8360