Fixes #8871: missing rudder_expected_reports.csv.res when starting the agent for the first time after an update #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "expected_reports_source" string => "${sys.workdir}/inputs/rudder_expected_reports.csv"; | ||
| "expected_reports_temp" string => "${expected_reports_source}.tmp"; | ||
| "expected_reports_file" string => "${expected_reports_source}.res"; | ||
| # We add the PID to the file name to be able to handle cuncurrent agent runs with separate expected reports | ||
| "expected_reports_file" string => "${sys.workdir}/state/rudder_expected_reports.${this.promiser_pid}.csv.res"; |
There was a problem hiding this comment.
Could you also add a comment here as to why we're placing the file in a different directory? (to avoid purging during update)
|
Commit modified |
amousset
force-pushed
the
bug_8871/missing_rudder_expected_reports_csv_res_when_starting_the_agent_for_the_first_time_after_an_update
branch
from
7c7ba41
to
478bf82
Compare
|
Commit modified |
amousset
force-pushed
the
bug_8871/missing_rudder_expected_reports_csv_res_when_starting_the_agent_for_the_first_time_after_an_update
branch
from
478bf82
to
9f55b99
Compare
| bundle agent _clean_old_expected_reports_file(days) { | ||
|
|
||
| files: | ||
| "${sys.workdir}/state/rudder_expected_reports.*.csv.res" |
|
This needs be moved into log_rudder in master. |
|
Commit modified |
amousset
force-pushed
the
bug_8871/missing_rudder_expected_reports_csv_res_when_starting_the_agent_for_the_first_time_after_an_update
branch
from
9f55b99
to
d4f4913
Compare
|
OK, looks good to me. Let's get some feedback on this before merging. |
…e agent for the first time after an update
amousset
force-pushed
the
bug_8871/missing_rudder_expected_reports_csv_res_when_starting_the_agent_for_the_first_time_after_an_update
branch
from
d4f4913
to
b42b0e6
Compare
|
Commit modified |
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8871