Fixes #10079: Add a generic method to merge two dict variables #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
amousset
force-pushed
the
ust_10079/add_a_generic_method_to_merge_two_dict_variables
branch
from
6dc40fc
to
bff2339
Compare
|
I thought this already existed |
|
Me too, but it seems not... |
peckpeck
reviewed
Jan 27, 2017
| # | ||
| # @parameter variable_prefix The prefix of the variable name | ||
| # @parameter variable_name The variable to define, the full name will be variable_prefix.variable_name | ||
| # @parameter first_variable The first variable, that will be overriden if necessary (in the form variable_prefix.variable_name) |
There was a problem hiding this comment.
Could you use the word source instead of overridden to avoid confusion about the state of the variable after the call
|
Commit modified |
amousset
force-pushed
the
ust_10079/add_a_generic_method_to_merge_two_dict_variables
branch
from
bff2339
to
6cc23b4
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10079