-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #8362: Adapt ncf tests to different platforms #550
Fixes #8362: Adapt ncf tests to different platforms #550
Conversation
First target set is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a welcomed change, but can we make sure it works also on sles ?
"service_name" string => "cron"; | ||
redhat:: | ||
"service_name" string => "crond"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redhat or sles ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or even better: !debian
aix:: | ||
"service_script" string => "syslogd"; | ||
!(redhat|aix):: | ||
"service_script" string => "ssh"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing sles case
"service_name" string => "cron"; | ||
redhat:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!aix.!debian:: ?
You are missing service_ensure_running_start.cf in the PR |
Let's merge the centos version, then test it, then add new OS |
PR replaced by #648 |
https://www.rudder-project.org/redmine/issues/8362