Fixes #10590: Generic method to remove separate parameters in key="values" line - Adapt reporting for ncf 1.0 #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is still a _logger call. |
|
Commit modified |
ncharles
force-pushed
the
ust_10590/generic_method_to_remove_separate_parameters_in_key_values_line_adapt_reporting_for_ncf_1_0
branch
from
40d39ac
to
becef82
Compare
amousset
reviewed
Apr 12, 2017
| pass2.!invalid_enclosing.line_with_key_present:: | ||
| "report" usebundle => _logger("Ensure ${parameter_regex} is not in ${key}${key_value_separator} values in ${file}", "${class_prefix}"); | ||
| "report" usebundle => _log("Ensure ${parameter_regex} is not in ${key}${key_value_separator} values in ${file}", "${class_prefix}"); |
…alues\" line - Adapt reporting for ncf 1.0
|
Commit modified |
ncharles
force-pushed
the
ust_10590/generic_method_to_remove_separate_parameters_in_key_values_line_adapt_reporting_for_ncf_1_0
branch
from
becef82
to
c6ac633
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10590