Refs #4873 - Add bundle command_execution_module() and adapt command_execution() and its tests #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2014 17:47
…execution() and its tests
…er of promises types in order to have reports
| "${command_name}" | ||
| module => "${module}", | ||
| contain => command_execution_module_contain("${shell}"), | ||
| classes => classes_generic("${class_prefix}"); |
There was a problem hiding this comment.
with this approach, you'll always have repaired status
You should have a convention in the output of the modules, to define when you have a repaired and when you have a kept
Idealy, if the module changes something, then it is repaired, else it is kept (or you can also fail if it fails)
There was a problem hiding this comment.
I suppose that we should use classes based on ${class_prefix} (i.e ${class_prefix}report{success,repaired,failed} but it would be difficult to incite users to echo in their scripts something like "command_execution_module__usr_share_local_bin_my_script_sh_report_success".
Is that what you suggest ?
|
We have no current use case for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #4873 - Add bundle command_execution_module() and adapt command_execution() and its tests
cf http://www.rudder-project.org/redmine/issues/4873