Fixes #10749: Broken package_state reporting #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should work with Rudder reporting if there is only one method_* call by package name. It is not a good general fix because it would cause double logging with other loggers. |
amousset
force-pushed
the
bug_10749/broken_package_state_reporting
branch
from
c688201
to
55e2a3d
Compare
|
Commit modified |
|
Do not merge for now, still testing. |
amousset
force-pushed
the
bug_10749/broken_package_state_reporting
branch
from
55e2a3d
to
5e75082
Compare
|
Commit modified |
|
@peckpeck Ready for review. |
|
Commit modified |
amousset
force-pushed
the
bug_10749/broken_package_state_reporting
branch
2 times, most recently
from
02646e5
to
ce426ad
Compare
|
Commit modified |
amousset
force-pushed
the
bug_10749/broken_package_state_reporting
branch
from
ce426ad
to
f244884
Compare
|
Commit modified |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10749