Add ncf helpers #62
Merged
Add ncf helpers #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -220,3 +221,63 @@ def get_all_techniques_metadata(include_methods_calls = True, alt_path = ''): | |||
|
|
|||
| return all_metadata | |||
|
|
|||
| def delete_technique_file(technique_name, alt_path=""): | |||
| """Delete a technique directory contained in a path""" | |||
There was a problem hiding this comment.
The naming/comments aren't making a whole lot of sense here: delete_file vs "Delete ... directory".
Let's just call this method "delete_technique", and avoid any references to files/directories.
|
all done! Thanks Jon! |
| raise NcfError(message) | ||
|
|
||
| def get_technique_content(technique_metadata): | ||
| """Get technique CFEngine file as string from its metadata""" |
|
updated again! |
| assert result | ||
|
|
||
| def test_default_technique_content(self): | ||
|
|
There was a problem hiding this comment.
I think it is mandatory in the Python unit testing framework we use to have a """string""" at the beginning of each test function. Either way, it is good practice to describe what the test does here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.