Fixes #11245: Add constraint on hash_type #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Aug 10, 2017
| @@ -21,7 +21,8 @@ | |||
| # | |||
| # @parameter source Source file (path relative to Rudder shared folder) | |||
| # @parameter destination Destination file (absolute path on the target node) | |||
| # @parameter hash_type Hash algorithm used to check if file is updated | |||
| # @parameter hash_type Hash algorithm used to check if file is updated (md5, sha1, sha256) | |||
There was a problem hiding this comment.
You should document that this parameter is always treated as md5 on cfengine.
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_11245/add_constraint_on_hash_type
branch
from
40ce705
to
7db7ac2
Compare
ncharles
reviewed
Aug 22, 2017
| @@ -21,7 +21,8 @@ | |||
| # | |||
| # @parameter source Source file (path relative to Rudder shared folder) | |||
| # @parameter destination Destination file (absolute path on the target node) | |||
| # @parameter hash_type Hash algorithm used to check if file is updated | |||
| # @parameter hash_type Hash algorithm used to check if file is updated (md5, sha1, sha256), only md5 can be used on cfengine agent | |||
There was a problem hiding this comment.
it's not used on cfengine, so why not simply state that it is not used for cfengine agent ?
There was a problem hiding this comment.
I will write that on cfengine it will always be treated as md5 for now
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_11245/add_constraint_on_hash_type
branch
from
7db7ac2
to
ed9ad0c
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11245