Fixes #11280: decline user_create generic method #628
Conversation
…_techniques_directory_pr'
…_method_uses_in_dsc_pr'
Fdall
force-pushed
the
ust_11280/decline_user_create_generic_method
branch
from
aa277f5
to
35f7c88
Compare
|
Commit modified |
|
Commit modified |
Fdall
force-pushed
the
ust_11280/decline_user_create_generic_method
branch
from
35f7c88
to
d234726
Compare
|
User_locked is not yet done. |
|
Commit modified |
Fdall
force-pushed
the
ust_11280/decline_user_create_generic_method
branch
from
d234726
to
29c246a
Compare
|
Commit modified |
Fdall
force-pushed
the
ust_11280/decline_user_create_generic_method
branch
2 times, most recently
from
d981ac8
to
050bcc2
Compare
|
Could you retarget to master? |
| # | ||
| ##################################################################################### | ||
|
|
||
| # @name user fullname |
| ##################################################################################### | ||
|
|
||
| # @name user fullname | ||
| # @description Define the fullname of the user, format must be. User must already exists. |
| # empty password accounts. | ||
| # | ||
| # @parameter login User login | ||
| # @parameter password User password |
There was a problem hiding this comment.
Specify the expected password format
|
|
||
| # @name User password hash | ||
| # @description Ensure a user's password. | ||
| # @documentation User must exists, password must be pre-hashed. Does not handle |
There was a problem hiding this comment.
Here we need examples I think, with a full hash, and a user without password.
|
|
||
| # @name User home | ||
| # @description Define the home of the user. User must already exists. | ||
| # @documentation This method does not create the user, nor the home directory. |
There was a problem hiding this comment.
It would be great to have an example here, it gives a quick overview of expected format of parameters.
| "args" slist => { "${login}", "${shell}" }; | ||
|
|
||
| classes: | ||
| "${login}_exists" expression => userexists("${login}"); |
There was a problem hiding this comment.
"args" is used as parameter for logs and the class is used in another one. I chose to always use an unique class to control action execution for more clarity.
| # | ||
| ##################################################################################### | ||
|
|
||
| # @name user uid |
| ##################################################################################### | ||
|
|
||
| # @name user uid | ||
| # @description Define the uid of the user. User must already exists, uid must be non-allowed. |
There was a problem hiding this comment.
I did not know it could be helpful in some cases... On the user_create technique, user creation failed if uid was already in use, moreover it is not the default behavior of most UNIX systems/
| "args" slist => { "${login}", "${uid}" }; | ||
|
|
||
| classes: | ||
| "${login}_exists" expression => userexists("${login}"); |
There was a problem hiding this comment.
"${login}_exists" could be simply replaced by "user_exists"
Fdall
force-pushed
the
ust_11280/decline_user_create_generic_method
branch
from
050bcc2
to
508b324
Compare
|
PR replaced by #632 |
https://www.rudder-project.org/redmine/issues/11280