Fixes #11602: Add a method to compute and format output #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
amousset
force-pushed
the
ust_11602/add_a_method_to_compute_and_format_output
branch
from
4711beb
to
02a35eb
Compare
peckpeck
reviewed
Oct 16, 2017
| # ``` | ||
| # variable_string("prefix", "var", "10"); | ||
| # variable_string_from_expression("prefix", "sum", "2.0+3.0", "%d"); | ||
| # variable_string_from_expression("prefix", "product", "3*${prefix.var}", "%d"); |
There was a problem hiding this comment.
You could use more example / documentation from cfengine
peckpeck
reviewed
Oct 16, 2017
| # @class_prefix variable_string_from_expression | ||
| # @class_parameter variable_name | ||
|
|
||
| bundle agent variable_string_from_expression(variable_prefix, variable_name, expression, format) |
There was a problem hiding this comment.
I'd prefer variable_string_from_math_expression
|
Commit modified |
amousset
force-pushed
the
ust_11602/add_a_method_to_compute_and_format_output
branch
from
02a35eb
to
b11bc0d
Compare
|
Commit modified |
amousset
force-pushed
the
ust_11602/add_a_method_to_compute_and_format_output
branch
from
b11bc0d
to
6b56f66
Compare
ncharles
reviewed
Oct 19, 2017
| @@ -0,0 +1,54 @@ | |||
| ####################################################### | |||
| # | |||
| # Read a file into a string | |||
|
Commit modified |
amousset
force-pushed
the
ust_11602/add_a_method_to_compute_and_format_output
branch
from
6b56f66
to
8c21bda
Compare
|
Commit modified |
amousset
force-pushed
the
ust_11602/add_a_method_to_compute_and_format_output
branch
from
8c21bda
to
ed680b4
Compare
|
Commit modified |
amousset
force-pushed
the
ust_11602/add_a_method_to_compute_and_format_output
branch
from
ed680b4
to
420448d
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11602