Fixes #11601: Add a variable_string_from_command method #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge for now, some small things to fix. |
amousset
force-pushed
the
ust_11601/add_a_variable_string_from_command_method
branch
from
d40dd18
to
e27c940
Compare
|
this looks ok, but it is scary |
|
Commit modified |
amousset
force-pushed
the
ust_11601/add_a_variable_string_from_command_method
branch
from
e27c940
to
2b99c52
Compare
|
Executing commands without the full path failed because execresult though the I move the |
ncharles
reviewed
Oct 19, 2017
| # | ||
| # We concatenate the return code as a three char string, and extract it after. | ||
| # | ||
| # /bin/true is necessary because execresult thinks the $() is an unexpanded variable. |
There was a problem hiding this comment.
can you update the doc to explain why the /bin/true is in the ${ } ?
|
Looks good to me |
|
Commit modified |
amousset
force-pushed
the
ust_11601/add_a_variable_string_from_command_method
branch
from
2b99c52
to
e9c84e6
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11601