Fixes #11812: Standardize generic methods name #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Nov 30, 2017
| @@ -17,6 +17,8 @@ | |||
| ##################################################################################### | |||
|
|
|||
| # @name File template expand | |||
| # @deprecated This method uses cfengine's template which is deprecated and not portable accross agents. | |||
|
Commit modified |
peckpeck
force-pushed
the
ust_11812/standardize_generic_methods_name
branch
from
4788d77
to
81be66c
Compare
|
Commit modified |
peckpeck
force-pushed
the
ust_11812/standardize_generic_methods_name
branch
from
81be66c
to
f36b0f2
Compare
amousset
reviewed
Nov 30, 2017
| @@ -17,6 +17,8 @@ | |||
| ##################################################################################### | |||
|
|
|||
| # @name File template expand | |||
| # @deprecated This method uses CFEngine's templating which is deprecated and not portable accross agents. | |||
There was a problem hiding this comment.
The is already a deprecated tag below.
amousset
reviewed
Nov 30, 2017
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| # @name Service action | |||
| # @description Trigger an action on a service using the approriate tool | |||
| # @action | |||
There was a problem hiding this comment.
Not always an action, could be "is-enabled" for example.
|
Commit modified |
peckpeck
force-pushed
the
ust_11812/standardize_generic_methods_name
branch
from
f36b0f2
to
17aa046
Compare
amousset
reviewed
Dec 1, 2017
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| # @name HTTP request check status with headers | |||
| # @description Checks status of an HTTP URL | |||
| # @action We don't know when a HTTP methods cause side effect, this can be an action or not depending on your server behaviour | |||
amousset
reviewed
Dec 1, 2017
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| # @name HTTP request sending content with headers | |||
| # @description Make an HTTP request with a specific header | |||
| # @action We don't know when a HTTP methods cause side effect, this can be an action or not depending on your server behaviour | |||
|
Commit modified |
peckpeck
force-pushed
the
ust_11812/standardize_generic_methods_name
branch
from
17aa046
to
803b511
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11812